deps: update inspector_protocol to c149e90e9ff5bf7#37574
deps: update inspector_protocol to c149e90e9ff5bf7#37574aduh95 wants to merge 2 commits intonodejs:masterfrom
Conversation
|
See #27770 Last time I updated |
|
Also see https://github.com/nodejs/node/commits/master/tools/inspector_protocol for the fixes that we float on top of it. |
benjamingr
left a comment
There was a problem hiding this comment.
Rubber stamp LGTM (and assuming Jinga 2 is now a dependency)
7165d33 to
1d993ec
Compare
|
In the current code on |
PR-URL: nodejs#29296 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
30f4a66 to
fa98a8b
Compare
|
It seems there are a lot of breaking changes in the update, I'm starting to wonder if I haven't pick a challenge too big for my skills. |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Hopefully this should fix the
linux-coverageGitHub Action.To update it, I used the following commands:
Then I had to update
src/inspector/node_inspector.gypito reflect the changes intools/inspector_protocol/inspector_protocol.gni.