Skip to content

Fix typo: "director" instead of "directory"#37523

Closed
humanwebpl wants to merge 1 commit intonodejs:masterfrom
humanwebpl:patch-1
Closed

Fix typo: "director" instead of "directory"#37523
humanwebpl wants to merge 1 commit intonodejs:masterfrom
humanwebpl:patch-1

Conversation

@humanwebpl
Copy link
Contributor

@humanwebpl humanwebpl commented Feb 26, 2021

Change fs.readdirSync() description from "Reads the contents of the director." to "Reads the contents of the directory."

@humanwebpl
Fix typo: "director" instead of "directory"
1ec8a89 
Change fs.readdirSync() description from "Reads the contents of the director." to "Reads the contents of the directory."
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Feb 26, 2021
@RaisinTen
Copy link
Member

RaisinTen commented Feb 26, 2021

Duplicate of #37522?

Trott
Trott approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but this is a duplicate of the change in #37522 so only one or the other will land.

@jasnell
Copy link
Member

jasnell commented Mar 1, 2021

Landed in 1ca4a9c

@jasnell jasnell closed this Mar 1, 2021
jasnell pushed a commit that referenced this pull request Mar 1, 2021
@humanwebpl @jasnell
doc: fix typo "director" instead of "directory"
1ca4a9c 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: #37523
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
lpinca pushed a commit to lpinca/node that referenced this pull request Mar 2, 2021
@humanwebpl @lpinca
doc: fix typo "director" instead of "directory"
796504d 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: nodejs#37523
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Mar 2, 2021
@humanwebpl @targos
doc: fix typo "director" instead of "directory"
dd7a04d 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: #37523
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 2, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@humanwebpl @targos
doc: fix typo "director" instead of "directory"
bbcc217 
Change fs.readdirSync() description from "Reads the contents of
the director." to "Reads the contents of the directory."

PR-URL: #37523
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@targos targos targos approved these changes

@Flarna Flarna Flarna approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@humanwebpl @RaisinTen @jasnell @Trott @benjamingr @targos @Flarna @HarshithaKP @nodejs-github-bot