src: fix alloc-dealloc-mismatch in node_snapshotable.h#37443
Closed
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Closed
src: fix alloc-dealloc-mismatch in node_snapshotable.h#37443RaisinTen wants to merge 1 commit intonodejs:masterfrom
RaisinTen wants to merge 1 commit intonodejs:masterfrom
Conversation
jasnell
approved these changes
Feb 19, 2021
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM but would like @joyeecheung to sign off also
RaisinTen
force-pushed
the
tools/fix-alloc-dealloc-mismatch-in-snapshot_builder.cc
branch
from
97f543c to
3789d14
Compare
RaisinTen
changed the title
RaisinTen
added
lib / src
Collaborator
RaisinTen
added
the
c++
joyeecheung
approved these changes
Feb 21, 2021
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
I can't see why there is a mismatch, but I guess whatever makes the linter happy...although this isn't a homogeneous array block, it's more like a block of memory whose layout is manually controlled by us since they are meant to be written as-is in blocks
Member
Author
|
@joyeecheung This was happening since the array was being allocated using Do you think it would be more appropriate to convert the delete[] calls to delete calls instead of this fix?
|
Member
|
@RaisinTen I see, we should use |
Collaborator
Member
Author
|
Test failures don't seem to be related to this patch. |
RaisinTen
added
the
author ready
Member
|
Landed in 954d911 |
RaisinTen
deleted the
tools/fix-alloc-dealloc-mismatch-in-snapshot_builder.cc
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37442