docs: clarify that async_hook callbacks cannot be async#37384
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
docs: clarify that async_hook callbacks cannot be async#37384jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
async_hooks
targos
approved these changes
Feb 15, 2021
lpinca
approved these changes
Feb 15, 2021
RaisinTen
approved these changes
Feb 16, 2021
marsonya
approved these changes
Feb 16, 2021
Lxxyx
approved these changes
Feb 17, 2021
Lxxyx
added
the
author ready
Flarna
approved these changes
Feb 17, 2021
Lxxyx
pushed a commit
that referenced
this pull request
Feb 18, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37384 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Member
|
Landed in 85cb9c6b5896 |
Member
|
Actually landed in bb35b6e |
Member
Whoops, I forgot I manually changed the commit message, thanks for the reminder |
targos
pushed a commit
that referenced
this pull request
Feb 28, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37384 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37384 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the init/before/after/destroy callbacks in async_hooks cannot be async functions.
Signed-off-by: James M Snell jasnell@gmail.com