Propose v5.1.0 by Fishrock123 · Pull Request #3736 · nodejs/node

Fishrock123 · 2015-11-10T16:25:43Z

Replaces #3700

I'm going to start just making PRs from the start in the future as my git remotes aren't set up the way github's hub tool likes. (Of course.)

cc @nodejs/release

Fishrock123 · 2015-11-10T16:27:50Z

@jasnell could you check my notes on the http_parser upgrade?

Fishrock123 · 2015-11-10T16:28:20Z

Previous CI (Still hanging.....): https://ci.nodejs.org/job/node-test-commit/1070/

cc @nodejs/build

jasnell · 2015-11-10T16:36:57Z

@Fishrock123 ... should likely indicate that the ACL added is a new request method. I would put a link to the RFC that defines it (https://www.ietf.org/rfc/rfc3744.txt). Other than that, LGTM

Fishrock123 · 2015-11-11T00:16:44Z

Need to remember to put #3519 (comment) into known issues. (cc @jasnell too)

Sounds like the CI will be back up tomorrow so this will be going out then.

Fishrock123 · 2015-11-11T17:24:03Z

Updated list:

[59cd28114d] - Add missing va_end before return (Ömer Fadıl Usta) #3565
[b663d2bbb5] - async_wrap: call callback in destructor (Trevor Norris) #3461
[eccbec99ea] - async_wrap: new instances get uid (Trevor Norris) #3461
[5d34c81a5c] - async_wrap: allow some hooks to be optional (Trevor Norris) #3461
[56673693cd] - buffer: neuter external nullptr buffers (Fedor Indutny) #3624
[8f5a2550a7] - build: omit -gline-tables-only for --enable-asan (Ben Noordhuis) #3680
[e888471a11] - child_process: don't fork bomb ourselves from -e (Ben Noordhuis) #3575
[47f3735e88] - cluster: send suicide message on disconnect (cjihrig) #3720
[d64a56cba5] - cluster: remove handles when disconnecting worker (Ben Noordhuis) #3677
[5ed30da5a0] - console: use 'label' argument for time and timeEnd (Roman Reiss) #3590
[9ef81ff5d3] - deps: update V8 to 4.6.85.31 (Michaël Zasso) #3698
[b48dbf9fce] - deps: upgrade npm to 3.3.12 (Rebecca Turner) #3685
[7caeb14e11] - (SEMVER-MINOR) deps: update http-parser to 2.6.0 (James M Snell) #3569
[08e0de59fa] - deps: upgrade npm to 3.3.10 (Rebecca Turner) #3599
[ac9e4ffe8e] - dns: prevent undefined values in results (Junliang Yan) #3696
[597f8751d1] - doc: add note on tls connection meta data methods (Tyler Henkel) #3746
[a32d9e31dc] - doc: add romankl to collaborators (Roman Klauke) #3725
[e5b9109d12] - doc: add thealphanerd to collaborators (Myles Borins) #3723
[a05a0b47e3] - doc: add saghul as a collaborator (Saúl Ibarra Corretgé)
[b14d9c5f16] - doc: add method links in events.markdown (Alejandro Oviedo) #3187
[44f779b112] - doc: add caveats of algs and key size in crypto (Shigeki Ohtsu) #3479
[a0db5fb355] - doc: stdout/stderr can block when directed to file (Ben Noordhuis) #3170
[409f29972e] - doc: rename iojs-* groups to nodejs-* (Steven R. Loomis) #3634
[801866280e] - doc: fix wrong date and known issue in changelog.md (James M Snell) #3650
[325c4c7af5] - doc: fix function param order in assert doc (David Woods) #3533
[045e04e531] - doc: typo fix in readme.md (Sam P Gallagher-Bishop) #3649
[7fd8f1371e] - doc: add note about timeout delay > TIMEOUT_MAX (Guilherme Souza) #3512
[7d0b589644] - doc: fix crypto spkac function descriptions (Jason Gerfen) #3614
[efa19bdcb5] - doc: add final full stop in CONTRIBUTING.md (Emily Aviva Kapor-Mater) #3576
[90723afe32] - doc: made code spans more visible in the API docs (phijohns) #3573
[73e40f0327] - docs: fs - change links to buffer encoding to Buffer class anchor (fansworld-claudio) #2796
[7a84fa6c60] - docs: fs - remove encoding list and link to buffer (fansworld-claudio)
[c96400c572] - gitignore: don't ignore 'debug' in deps/npm (Rebecca Turner) #3599
[a7f28a098e] - http: remove unneeded cb check from setTimeout() (Ashok Suthar) #3631
[d2b5dcb2de] - lib: return boolean from child.send() (Rich Trott) #3577
[89285db128] - module: remove unnecessary JSON.stringify (Andres Suarez) #3578
[75dbafc3f8] - repl: To exit, press ^C again or type .exit. (Hemanth.HM) #3368
[5073da0481] - repl: don't crash if cannot open history file (Evan Lucas) #3630
[02e012e984] - src: force line buffering for stderr (Rich Trott) #3701
[2498e29344] - src: Revert "nix stdin _readableState.reading" (Roman Reiss) #3490
[65cd03cda6] - src: wrap source before doing syntax check (Evan Lucas) #3587
[d72bb1e96a] - _Revert_ "src: fix stuck debugger process" (Ben Noordhuis) #3585
[1c8a7c6351] - test: enhance fs-watch-recursive test (Sakthipriyan Vairamani) #2599
[81997840f2] - test: fix test-module-loading-error for musl (Hugues Malphettes) #3657
[9cdceac782] - test: use really invalid hostname (Sakthipriyan Vairamani) #3711
[f3594e77b2] - test: fix test-net-persistent-keepalive for AIX (Imran Iqbal) #3646
[81522480f1] - test: more regression tests for minDHSize option (Ben Noordhuis) #3629
[935b97769e] - test: add regression test for 512 bits DH key (Ben Noordhuis) #3629
[e302c33bb0] - test: mark http-pipeline-flood flaky (Rich Trott) #3616
[5977963bce] - test: remove flaky designation from ls-no-sslv3 (Rich Trott) #3620
[1e98d90db8] - test: add regression test for --debug-brk -e 0 (Ben Noordhuis) #3585
[d036b35349] - tools: enforce throw new Error() with lint rule (Rich Trott) #3714
[38bb0d864e] - tools: Use throw new Error() consistently (Rich Trott) #3714
[e40d28283a] - tools: update npm test tooling for 3.3.10+ (Rebecca Turner) #3599
[cbd358ce33] - tools: fix gyp to work on MacOSX without XCode (Shigeki Ohtsu) iojs/io.js#1325
[3137e46cb8] - tools: update gyp to b3cef02 (Imran Iqbal) #3487
[9a45c21e6c] - util: use regexp instead of str.replace().join() (qinjia) #3689

CI: https://ci.nodejs.org/job/node-test-commit/1090/

Fishrock123 · 2015-11-11T18:27:36Z

Another CI: https://ci.nodejs.org/job/node-test-commit/1093/

rvagg · 2015-11-12T11:54:38Z

CI isn't quite ready yet, there's a tiny bit of hair left on dem yaks.

Current status can be seen in this nightly directory: https://nodejs.org/download/nightly/v5.0.1-nightly2015111247f3735e88/ - missing as of now are Windows (minor issues left to solve) and Linux 32-bit (still to be fully reprovisioned).

@joaocgreis could you update this issue when the Windows release machines are ready to roll, @jbergstroem can you report on the CentOS5 machines too please?

joaocgreis · 2015-11-12T12:57:50Z

@rvagg @Fishrock123 Windows release machines ready to use!

Fishrock123 · 2015-11-12T14:37:32Z

Another CI: https://ci.nodejs.org/job/node-test-commit/1097/

Fishrock123 · 2015-11-12T15:06:20Z

@joaocgreis Are you sure the windows CI is working correctly? https://ci.nodejs.org/job/node-test-binary-windows/255/

Fishrock123 · 2015-11-12T15:12:48Z

I can't even get https://ci.nodejs.org/job/node-test-commit-smartos/287/nodes=smartos14-64/tapTestReport/ to look at it..

Fishrock123 · 2015-11-12T15:14:48Z

Looks like most of the ARM machines aren't connecting. Maybe Rod's internet is down?

https://ci.nodejs.org/job/node-test-commit/1097/
https://ci.nodejs.org/job/node-test-binary-arm/465/

Fishrock123 · 2015-11-12T15:42:49Z

Note to self: #3617 for known issues

joaocgreis · 2015-11-12T20:25:51Z

@Fishrock123 The release servers are ready, but I'm still working on the test servers.

Fishrock123 · 2015-11-12T20:52:04Z

Well, we haven't had full CI runs for almost a week so I'm less than sure of actually doing a release.

jbergstroem · 2015-11-12T21:20:12Z

centos5-32 release is ready.

Fishrock123 · 2015-11-12T22:10:55Z

New CI: https://ci.nodejs.org/job/node-test-commit/1103/

rvagg · 2015-11-14T07:20:33Z

Release machines should be good to go now, the remaining Linux 64-bit issue has been sorted out and we have a successful build @ https://nodejs.org/download/nightly/v5.0.1-nightly2015111484bb74547d/

Fishrock123 · 2015-11-15T22:28:48Z

Another CI: https://ci.nodejs.org/job/node-test-commit/1132/

Been sick so I haven't caught up to all the new commits and probably won't until tomorrow/tuesday.

Still looking at a tuesday release now.

Fishrock123 · 2015-11-17T16:49:40Z

New CI: https://ci.nodejs.org/job/node-test-commit/1161/

Left #3755 for now because I'd like confirmation that it is not semver-major.

Fishrock123 · 2015-11-17T17:02:04Z

#3755 (comment), landing that commit in v5.x.

PR-URL: nodejs#3736

jasnell · 2015-11-17T19:36:18Z

LGTM

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) #3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) #3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) #3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) #3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) #3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) #3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) #3755. * v8: Added some more useful post-mortem data (Fedor Indutny) #3779. PR-URL: #3736

PR-URL: #3736

Fishrock123 · 2015-11-17T19:46:32Z

Amended the commit description, actually landed in 2f16be2...3b69060

Fishrock123 · 2015-11-17T19:48:24Z

Building @ https://ci.nodejs.org/job/iojs+release/287/

Fishrock123 · 2015-11-17T20:03:37Z

^ cc @nodejs/build ppcle and rpi1 just failed to build. ^

Fishrock123 · 2015-11-17T20:46:25Z

2nd run as suggested by @jbergstroem: https://ci.nodejs.org/job/iojs+release/288/

PR-URL: #3736

Refs: nodejs/node#3736

Fishrock123 · 2015-11-17T22:06:58Z

All done! https://nodejs.org/en/blog/release/v5.1.0/

References: - nodejs/docker-node#67 - nodejs/node#3736

jasnell · 2015-11-18T04:46:52Z

Woot! Awesome job @Fishrock123

References: - nodejs/docker-node#67 - nodejs/node#3736

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) nodejs/node#3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) nodejs/node#3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) nodejs/node#3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) nodejs/node#3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) nodejs/node#3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) nodejs/node#3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) nodejs/node#3755. * v8: Added some more useful post-mortem data (Fedor Indutny) nodejs/node#3779. PR-URL: nodejs/node#3736

PR-URL: nodejs/node#3736

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) nodejs/node#3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) nodejs/node#3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) nodejs/node#3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) nodejs/node#3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) nodejs/node#3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) nodejs/node#3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) nodejs/node#3755. * v8: Added some more useful post-mortem data (Fedor Indutny) nodejs/node#3779. PR-URL: nodejs/node#3736

PR-URL: nodejs/node#3736

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) nodejs/node#3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) nodejs/node#3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) nodejs/node#3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) nodejs/node#3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) nodejs/node#3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) nodejs/node#3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) nodejs/node#3755. * v8: Added some more useful post-mortem data (Fedor Indutny) nodejs/node#3779. PR-URL: nodejs/node#3736

PR-URL: nodejs/node#3736

Notable changes: * buffer: The `noAssert` option for many buffer functions will now silently drop invalid write values rather than crashing (P.S.V.R) nodejs/node#3767. - This makes the behavior match what the docs suggest. * child_process: `child.send()` now properly returns a boolean like the docs suggest (Rich Trott) nodejs/node#3577. * doc: All of the API docs have been re-ordered so as to read in alphabetical order (Tristian Flanagan) nodejs/node#3662. * http_parser: update http-parser to 2.6.0 from 2.5.0 (James M Snell) nodejs/node#3569. - Now supports the following HTTP methods: `LINK`, `UNLINK`, `BIND`, `REBIND`, `UNBIND`. - Also added ACL and IPv6 Zone ID support. * npm: upgrade npm to 3.3.12 from v3.3.6 (Rebecca Turner) nodejs/node#3685. - See the release notes for https://github.com/npm/npm/releases/tag/v3.3.7, https://github.com/npm/npm/releases/tag/v3.3.8, https://github.com/npm/npm/releases/tag/v3.3.9, https://github.com/npm/npm/releases/tag/v3.3.10, https://github.com/npm/npm/releases/tag/v3.3.11, and https://github.com/npm/npm/releases/tag/v3.3.12 for more details. * repl: The REPL no longer crashes if the persistent history file cannot be opened (Evan Lucas) nodejs/node#3630. * tls: The default `sessionIdContext` now uses SHA1 in FIPS mode rather than MD5 (Stefan Budeanu) nodejs/node#3755. * v8: Added some more useful post-mortem data (Fedor Indutny) nodejs/node#3779. PR-URL: nodejs/node#3736

PR-URL: nodejs/node#3736

References: - nodejs/docker-node#67 - nodejs/node#3736

Fishrock123 added the meta Issues and PRs related to the general management of the project. label Nov 10, 2015

Fishrock123 mentioned this pull request Nov 10, 2015

Release proposal: v5.1.0 #3700

Closed

Fishrock123 force-pushed the propose-v5.1.0 branch from 3ee78a4 to 6784cb0 Compare November 10, 2015 16:27

Trott mentioned this pull request Nov 11, 2015

"tns platform add ios" generates Fatal Error: v8::ArrayBuffer::Neuter NativeScript/nativescript-cli#1129

Closed

yosuke-furukawa mentioned this pull request Nov 16, 2015

TypeError: Cannot read property 'remove' of undefined at close (cluster.js:497:15) #3843

Closed

bnoordhuis mentioned this pull request Nov 17, 2015

cluster: remove handles when disconnecting worker #3677

Merged

Fishrock123 force-pushed the propose-v5.1.0 branch from 6784cb0 to a4f3256 Compare November 17, 2015 17:39

Working on v5.1.1

e93eed3

PR-URL: nodejs#3736

Fishrock123 force-pushed the propose-v5.1.0 branch from c003972 to e93eed3 Compare November 17, 2015 19:34

Fishrock123 merged commit e93eed3 into nodejs:v5.x Nov 17, 2015

Fishrock123 added a commit that referenced this pull request Nov 17, 2015

Working on v5.1.1

3b69060

PR-URL: #3736

Fishrock123 added a commit that referenced this pull request Nov 17, 2015

2015-11-17, Version 5.1.0 (Stable)

29cd119

PR-URL: #3736

Fishrock123 added a commit to nodejs/nodejs.org that referenced this pull request Nov 17, 2015

Add v5.1.0 changelog

7244bc3

Refs: nodejs/node#3736

hmalphettes mentioned this pull request Nov 18, 2015

Upgrade node-v5.0.0 to node-v5.1.0 nodejs/docker-node#67

Merged

hmalphettes added a commit to hmalphettes/official-images that referenced this pull request Nov 18, 2015

Upgrade node-v5.0.0 to node-v5.1.0

2130594

References: - nodejs/docker-node#67 - nodejs/node#3736

hmalphettes mentioned this pull request Nov 21, 2015

Upgrade node-v5.0.0 to node-v5.1.0 docker-library/official-images#1205

Merged

jasnell mentioned this pull request Dec 17, 2015

Release 4.2.4 Planning #4321

Closed

pierreozoux pushed a commit to pierreozoux/official-images that referenced this pull request Jan 7, 2016

Upgrade node-v5.0.0 to node-v5.1.0

6483f19

References: - nodejs/docker-node#67 - nodejs/node#3736

bbondy pushed a commit to brave/node that referenced this pull request Mar 13, 2016

Working on v5.1.1

5d0956d

PR-URL: nodejs/node#3736

bbondy pushed a commit to brave/node that referenced this pull request Mar 14, 2016

Working on v5.1.1

520aeb7

PR-URL: nodejs/node#3736

bbondy pushed a commit to brave/node that referenced this pull request Mar 14, 2016

Working on v5.1.1

35f4fae

PR-URL: nodejs/node#3736

bbondy pushed a commit to brave/node that referenced this pull request Mar 15, 2016

Working on v5.1.1

2971b90

PR-URL: nodejs/node#3736

RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016

Upgrade node-v5.0.0 to node-v5.1.0

c1b6336

References: - nodejs/docker-node#67 - nodejs/node#3736

Uh oh!

Conversation

Fishrock123 commented Nov 10, 2015

Uh oh!

Fishrock123 commented Nov 10, 2015

Uh oh!

Fishrock123 commented Nov 10, 2015

Uh oh!

jasnell commented Nov 10, 2015

Uh oh!

Fishrock123 commented Nov 11, 2015

Uh oh!

Fishrock123 commented Nov 11, 2015

Uh oh!

Fishrock123 commented Nov 11, 2015

Uh oh!

rvagg commented Nov 12, 2015

Uh oh!

joaocgreis commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

joaocgreis commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

jbergstroem commented Nov 12, 2015

Uh oh!

Fishrock123 commented Nov 12, 2015

Uh oh!

rvagg commented Nov 14, 2015

Uh oh!

Fishrock123 commented Nov 15, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

jasnell commented Nov 17, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

Fishrock123 commented Nov 17, 2015

Uh oh!

jasnell commented Nov 18, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants