stream: add AbortSignal support to promisified pipeline#37359
Closed
Linkgoron wants to merge 1 commit intonodejs:masterfrom
Closed
stream: add AbortSignal support to promisified pipeline#37359Linkgoron wants to merge 1 commit intonodejs:masterfrom
Linkgoron wants to merge 1 commit intonodejs:masterfrom
Conversation
benjamingr
reviewed
Feb 13, 2021
54d0ed7 to
0100a60
Compare
Member
Member
|
@benjamingr: Isn't the usual pattern to send an options object i.e. |
Member
|
Yeah I tend to prefer options with a signal too |
add support for AbortSignal to promisified pipeline. Resolves: nodejs#37321
0100a60 to
dc74b35
Compare
Contributor
Author
|
I've updated the docs, and also changed it to receive an @ronag I could also "push" the changes from the promise version, into the regular pipeline implementation, so that both the "regular" pipeline and promisified pipeline support cancellation. where the API will change to: Similarly to what was done in |
ronag
approved these changes
Feb 14, 2021
benjamingr
approved these changes
Feb 14, 2021
marsonya
approved these changes
Feb 14, 2021
Collaborator
Lxxyx
approved these changes
Feb 18, 2021
Member
|
Landed in 38f6e5a 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for AbortSignal to promisified pipeline (in
stream/promises)This resolves #37321.
As an aside, this wouldn't be hard to actually push it into pipeline itself and support it in the regular version, however it's already pretty simple to just call
addAbortSignalfromstreamon the received pipeline.make -j4 test(UNIX), orvcbuild test(Windows) passes