module: use optional chaining in cjs/loader.js#37238
Closed
RaisinTen wants to merge 0 commit intonodejs:masterfrom
Closed
module: use optional chaining in cjs/loader.js#37238RaisinTen wants to merge 0 commit intonodejs:masterfrom
RaisinTen wants to merge 0 commit intonodejs:masterfrom
Conversation
Collaborator
Member
Author
|
Benchmark CI for module: No significant perf regressions |
aduh95
approved these changes
Feb 5, 2021
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
LGTM if benchmark results don't show perf regression
Member
Author
|
@aduh95 benchmark looks good! 🎉 |
RaisinTen
added
the
author ready
Lxxyx
approved these changes
Feb 5, 2021
benjamingr
approved these changes
Feb 5, 2021
Member
|
Non-blocking from me, but I think whether the benchmarks look good in this case may be a matter of opinion. It shows three statistically-significant (but also, yes, small) regressions. Might be interesting to run again to see if they are persistent or not. Benchmark CI re-run for comparison: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/937/ |
ExE-Boss
approved these changes
Feb 7, 2021
Member
|
Benchmark re-run confirms no significant changes in benchmark results. |
Trott
approved these changes
Feb 9, 2021
Trott
pushed a commit
to RaisinTen/node
that referenced
this pull request
Feb 9, 2021
PR-URL: nodejs#37238 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Trott
force-pushed
the
module/add-optional-chaining-in-cjs-loader
branch
from
5abd9c2 to
fdd7a87
Compare
Member
|
Landed in fdd7a87 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
PR-URL: #37238 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.