test: skip tests consistently in parallel.status#37035
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
test: skip tests consistently in parallel.status#37035Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Trott
added
flaky-test
aduh95
approved these changes
Jan 23, 2021
This comment has been minimized.
This comment has been minimized.
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when they fail) and others are marked SKIP (which means the results don't affect CI at all). There doesn't seem to be any reason for the difference. Mark them all as SKIP as IBM i for consistency and to have the luxury of a green daily CI. We'll want these to be at least SKIP,FLAKY (and preferably not skipped at all) before IBM i is supported.
Trott
force-pushed
the
ibmi-consistency
branch
from
7cd7d4a to
17d7afe
Compare
Trott
changed the title
Trott
added
request-ci
Collaborator
benjamingr
approved these changes
Jan 27, 2021
benjamingr
pushed a commit
that referenced
this pull request
Jan 27, 2021
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when they fail) and others are marked SKIP (which means the results don't affect CI at all). There doesn't seem to be any reason for the difference. Mark them all as SKIP as IBM i for consistency and to have the luxury of a green daily CI. We'll want these to be at least SKIP,FLAKY (and preferably not skipped at all) before IBM i is supported. PR-URL: #37035 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
|
Landed in e331046 🎉 (note I slightly amended the commit message since one line was more than 70 chars.) |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when they fail) and others are marked SKIP (which means the results don't affect CI at all). There doesn't seem to be any reason for the difference. Mark them all as SKIP as IBM i for consistency and to have the luxury of a green daily CI. We'll want these to be at least SKIP,FLAKY (and preferably not skipped at all) before IBM i is supported. PR-URL: #37035 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when they fail) and others are marked SKIP (which means the results don't affect CI at all). There doesn't seem to be any reason for the difference. Mark them all as SKIP as IBM i for consistency and to have the luxury of a green daily CI. We'll want these to be at least SKIP,FLAKY (and preferably not skipped at all) before IBM i is supported. PR-URL: #37035 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are marked SKIP,FLAKY (resulting in yellow/unstable CI when
they fail) and others are marked SKIP (which means the results don't
affect CI at all). There doesn't seem to be any reason for the
difference. Mark them all as SKIP as IBM i for consistency and to have
the luxury of a green daily CI. We'll want these to be at least
SKIP,FLAKY (and preferably not skipped at all) before IBM i is supported.