http: fix ClientRequest unhandled errors#36970
Closed
ronag wants to merge 7 commits intonodejs:masterfrom
Closed
Conversation
ClientRequest could someone cause an unhandled error from socket. Fixes: nodejs#36931
ronag
added
http
ronag
commented
Jan 16, 2021
ronag
commented
Jan 16, 2021
lpinca
reviewed
Jan 16, 2021
lpinca
approved these changes
Jan 16, 2021
ronag
added
the
author ready
Member
Author
|
@nodejs/http |
lpinca
reviewed
Jan 16, 2021
Collaborator
ronag
removed
the
author ready
Member
Author
|
Test needs improvment. |
Contributor
|
I cannot reproduce the timeout error on |
dnlup
approved these changes
Jan 18, 2021
benjamingr
approved these changes
Jan 18, 2021
ronag
added
the
author ready
Collaborator
dnlup
approved these changes
Feb 3, 2021
Collaborator
lpinca
reviewed
Feb 3, 2021
Co-authored-by: Luigi Pinca <[email protected]>
Collaborator
lpinca
reviewed
Feb 3, 2021
Co-authored-by: Luigi Pinca <[email protected]>
Collaborator
ronag
added a commit
that referenced
this pull request
Feb 3, 2021
ClientRequest could someone cause an unhandled error from socket. Fixes: #36931 PR-URL: #36970 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Member
Author
|
Landed in fe43bd8 |
danielleadams
pushed a commit
that referenced
this pull request
Feb 16, 2021
ClientRequest could someone cause an unhandled error from socket. Fixes: #36931 PR-URL: #36970 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientRequest could somtimes cause an unhandled error from socket.
Fixes: #36931