[v10.x backport] doc: add release key for Richard Lau#36835
Closed
kmur911 wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
[v10.x backport] doc: add release key for Richard Lau#36835kmur911 wants to merge 1 commit intonodejs:v10.x-stagingfrom
kmur911 wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
Because Richard Lau published 10.23.1 we need his public key added to the README to prevent gpg errors when people try to verify the signature.
Contributor
|
What you want is to backport #34397. Backporting PRs needs to follow a set of rules described in https://github.com/nodejs/node/blob/master/doc/guides/backporting-to-release-lines.md. We may want to add some checks in the future to make sure that changes to release keys have been backported before each release. /cc @nodejs/lts @richardlau |
aduh95
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because Richard Lau published 10.23.1 we need his public key added to the README to prevent gpg errors when people try to verify the signature.
Note: this is my first PR to this repo, I'm not sure if I should be merging the fix into this branch or somewhere else, really I want it associated with the 10.23.1 tag but I don't see one.