doc: add warning about Windows process groups#3681
Closed
r-52 wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add warning about Windows process groups#3681r-52 wants to merge 1 commit intonodejs:masterfrom
r-52 wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
doc
Contributor
|
IMHO, this should be added to known issues rather than being a documented behaviour. We might be able to implement this in the future to make it work on Windows. |
Member
|
I think people are more likely to read the documentation than the release notes when something doesn't work. This PR LGTM FWIW but "Ref.-Issue:" should be "Refs:" in the commit log. |
Contributor
Author
|
@pmq20 I thought that the docs are probably a more prominent place for such a warning/ disclaimer - just in case that someone wont read the full changelog. |
Member
|
@romankl ... can you please rebase and update? |
This commit adds a warning for Windows platforms. `process.kill` wont kill a process group on Windows and instead it throws an error. Refs: nodejs#3617
Contributor
Author
|
@jasnell done - thanks for the reminder! |
Member
|
LGTM! |
Member
|
Landed in 406c596 |
Closed
Merged
This was referenced Mar 29, 2020
This was referenced Mar 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a warning for Windows platforms.
process.killwont kill a process group on Windows and instead it throws an error.Ref.-Issue: #3617