Skip to content

doc: clarify that --require only supports cjs#36806

Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:clarify-require-cli-cjs
Closed

doc: clarify that --require only supports cjs#36806
jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell:clarify-require-cli-cjs

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Jan 5, 2021

Fixes: #35103

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Jan 5, 2021
MylesBorins
MylesBorins approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2021
@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 6, 2021
@jasnell
Copy link
Member Author

jasnell commented Jan 6, 2021

This shouldn't need to wait the full time to land. Please 👍🏻 to fast track

@jasnell
Copy link
Member Author

jasnell commented Jan 6, 2021

Landed in 9d35b92

@jasnell jasnell closed this Jan 6, 2021
jasnell added a commit that referenced this pull request Jan 6, 2021
@jasnell
doc: clarify that --require only supports cjs
9d35b92 
Fixes: #35103

PR-URL: #36806
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@jasnell @danielleadams
doc: clarify that --require only supports cjs
a7bb4da 
Fixes: #35103

PR-URL: #36806
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: clarify that --require only supports cjs
1521a59 
Fixes: #35103

PR-URL: #36806
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@watilde watilde watilde approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@aduh95 aduh95 aduh95 approved these changes

@HarshithaKP HarshithaKP HarshithaKP approved these changes

+1 more reviewer

@MylesBorins MylesBorins MylesBorins approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--require doesn't work with import

8 participants

@jasnell @MylesBorins @addaleax @watilde @BethGriggs @aduh95 @HarshithaKP @nodejs-github-bot