Closed
Conversation
nodejs-github-bot
added
the
meta
himself65
approved these changes
Jan 2, 2021
aduh95
approved these changes
Jan 2, 2021
Lxxyx
approved these changes
Jan 3, 2021
yashLadha
approved these changes
Jan 3, 2021
yashLadha
added
the
author ready
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 4, 2021
Replace checklist with a list. Clarify when things like tests and benchmarks are needed. PR-URL: nodejs#36739 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
Member
Author
|
Landed in 551251e |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Replace checklist with a list. Clarify when things like tests and benchmarks are needed. PR-URL: #36739 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Replace checklist with a list. Clarify when things like tests and benchmarks are needed. PR-URL: #36739 Reviewed-By: Zeyu Yang <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Yash Ladha <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace checklist with a list. Clarify when things like tests and
benchmarks are needed.
Checklist