test: increase coverage for assert/calltracker#36728
Closed
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Closed
test: increase coverage for assert/calltracker#36728Lxxyx wants to merge 1 commit intonodejs:masterfrom
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Conversation
1. test calls fn parameter is number Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30 2. test calls fn parameter is undefined Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33
Trott
approved these changes
Jan 10, 2021
Collaborator
Lxxyx
added
the
author ready
Lxxyx
added a commit
that referenced
this pull request
Jan 27, 2021
1. test calls fn parameter is number Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30 2. test calls fn parameter is undefined Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33 PR-URL: #36728 Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in 7016c61 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
1. test calls fn parameter is number Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30 2. test calls fn parameter is undefined Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33 PR-URL: #36728 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
1. test calls fn parameter is number Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30 2. test calls fn parameter is undefined Refs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33 PR-URL: #36728 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test calls
fnparameter isnumberRefs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L30
test calls
fnparameter isundefinedRefs: https://coverage.nodejs.org/coverage-51b43675067fafaa/lib/internal/assert/calltracker.js.html#L33
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes