Closed
Conversation
Trott
approved these changes
Jan 1, 2021
watilde
approved these changes
Jan 1, 2021
github-actions
bot
removed
the
request-ci
yashLadha
approved these changes
Jan 1, 2021
Contributor
|
Commit message can be improved though 😅 . Like using a substem |
Contributor
|
@pmj642 You can amend and then force push it. |
Contributor
Author
|
@yashLadha I actually found one more typo in the same file, so I was thinking of adding it to the same PR. |
jasnell
approved these changes
Jan 2, 2021
yashLadha
added
the
author ready
github-actions
bot
removed
the
request-ci
yashLadha
pushed a commit
that referenced
this pull request
Jan 4, 2021
PR-URL: #36719 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: James M Snell <[email protected]>
Contributor
|
Landed in 8b8620d |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36719 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36719 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Yash Ladha <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes