test: increase read file abort coverage#36716
Closed
shootermv wants to merge 1 commit intonodejs:masterfrom
Closed
test: increase read file abort coverage#36716shootermv wants to merge 1 commit intonodejs:masterfrom
shootermv wants to merge 1 commit intonodejs:masterfrom
Conversation
shootermv
force-pushed
the
increase-abort-readfile-test-coverage
branch
from
d347db7 to
5a80156
Compare
benjamingr
approved these changes
Jan 1, 2021
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
LGTM, I would make the comment shorter, thanks for this :)
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Jan 2, 2021
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Jan 2, 2021
Collaborator
Collaborator
Member
|
Thanks! 🙏 Landed in 8c3cdce 🚀 |
benjamingr
pushed a commit
that referenced
this pull request
Jan 27, 2021
PR-URL: #36716 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #36716 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #36716 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.