module: refactor to avoid unsafe array iteration

[aduh95]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[PoojaDurgad]

CI: https://ci.nodejs.org/job/node-test-pull-request/35189/

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/851/ (queued, will 404 until it starts)

[Trott]

LGTM if benchmarks are OK

[aduh95]

Benchmark didn't show any significant perf improvement or regression:

                                                                                   confidence improvement accuracy (*)    (**)   (***)
 module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/'                 **     -4.18 %       ±2.74%  ±3.65%  ±4.74%
 module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/'                     **      6.20 %       ±4.37%  ±5.88%  ±7.79%

Details

                                                                                   confidence improvement accuracy (*)    (**)   (***)
 module/module-loader-circular.js n=10000                                                         -1.26 %       ±3.27%  ±4.35%  ±5.67%
 module/module-loader-deep.js cache='false' files=1000 ext=''                                      1.15 %       ±3.53%  ±4.70%  ±6.11%
 module/module-loader-deep.js cache='false' files=1000 ext='.js'                                  -0.30 %       ±3.82%  ±5.08%  ±6.61%
 module/module-loader-deep.js cache='true' files=1000 ext=''                                      -4.85 %       ±5.63%  ±7.54%  ±9.92%
 module/module-loader-deep.js cache='true' files=1000 ext='.js'                                   -1.06 %      ±10.95% ±14.57% ±18.98%
 module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/'                 **     -4.18 %       ±2.74%  ±3.65%  ±4.74%
 module/module-loader.js cache='false' n=1000 files=500 dir='abs' name=''                          0.70 %       ±3.48%  ±4.63%  ±6.03%
 module/module-loader.js cache='false' n=1000 files=500 dir='abs' name='/index.js'                 3.03 %       ±5.00%  ±6.69%  ±8.78%
 module/module-loader.js cache='false' n=1000 files=500 dir='rel' name='/'                         1.81 %       ±5.89%  ±7.91% ±10.43%
 module/module-loader.js cache='false' n=1000 files=500 dir='rel' name=''                          1.61 %       ±4.77%  ±6.37%  ±8.33%
 module/module-loader.js cache='false' n=1000 files=500 dir='rel' name='/index.js'                -1.54 %       ±3.50%  ±4.66%  ±6.07%
 module/module-loader.js cache='false' n=1 files=500 dir='abs' name='/'                           -0.47 %       ±5.77%  ±7.69% ±10.02%
 module/module-loader.js cache='false' n=1 files=500 dir='abs' name=''                            -0.13 %       ±8.44% ±11.23% ±14.61%
 module/module-loader.js cache='false' n=1 files=500 dir='abs' name='/index.js'                   -2.37 %       ±5.13%  ±6.83%  ±8.89%
 module/module-loader.js cache='false' n=1 files=500 dir='rel' name='/'                           -0.35 %       ±4.47%  ±5.94%  ±7.73%
 module/module-loader.js cache='false' n=1 files=500 dir='rel' name=''                            -2.24 %       ±4.92%  ±6.55%  ±8.52%
 module/module-loader.js cache='false' n=1 files=500 dir='rel' name='/index.js'                    1.31 %       ±4.47%  ±5.95%  ±7.74%
 module/module-loader.js cache='true' n=1000 files=500 dir='abs' name='/'                         -2.17 %       ±2.28%  ±3.04%  ±3.95%
 module/module-loader.js cache='true' n=1000 files=500 dir='abs' name=''                          -0.13 %       ±1.59%  ±2.11%  ±2.75%
 module/module-loader.js cache='true' n=1000 files=500 dir='abs' name='/index.js'                  1.39 %       ±4.52%  ±6.08%  ±8.05%
 module/module-loader.js cache='true' n=1000 files=500 dir='rel' name='/'                         -1.12 %       ±2.06%  ±2.77%  ±3.64%
 module/module-loader.js cache='true' n=1000 files=500 dir='rel' name=''                           0.29 %       ±2.18%  ±2.91%  ±3.78%
 module/module-loader.js cache='true' n=1000 files=500 dir='rel' name='/index.js'                 -0.66 %       ±5.76%  ±7.66%  ±9.97%
 module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/'                     **      6.20 %       ±4.37%  ±5.88%  ±7.79%
 module/module-loader.js cache='true' n=1 files=500 dir='abs' name=''                             -3.04 %       ±5.49%  ±7.32%  ±9.53%
 module/module-loader.js cache='true' n=1 files=500 dir='abs' name='/index.js'                     3.04 %       ±4.17%  ±5.57%  ±7.30%
 module/module-loader.js cache='true' n=1 files=500 dir='rel' name='/'                             0.78 %       ±4.51%  ±6.00%  ±7.82%
 module/module-loader.js cache='true' n=1 files=500 dir='rel' name=''                             -2.94 %       ±3.47%  ±4.64%  ±6.09%
 module/module-loader.js cache='true' n=1 files=500 dir='rel' name='/index.js'                    -1.87 %       ±5.52%  ±7.41%  ±9.77%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 29 comparisons, you can thus
expect the following amount of false-positive results:
  1.45 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.29 false positives, when considering a   1% risk acceptance (**, ***),
  0.03 false positives, when considering a 0.1% risk acceptance (***)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35298/

[aduh95]

Landed in 5f2bb88