Skip to content

stream: only use legacy close listeners if not willEmitClose#36649

Closed
ronag wants to merge 1 commit intonodejs:masterfrom
nxtedition:legacy-close
Closed

stream: only use legacy close listeners if not willEmitClose#36649
ronag wants to merge 1 commit intonodejs:masterfrom
nxtedition:legacy-close

Conversation

@ronag
Copy link
Member

@ronag ronag commented Dec 27, 2020

Some streams that willEmitClose unecessarily fallback to legacy
events.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@ronag
stream: only use legacy close listeners if not willEmitClose
fb13f93 
Some streams that willEmitClose unecessarily fallback to legacy
events.
@ronag ronag requested a review from mcollina December 27, 2020 20:49
@ronag
Copy link
Member Author

ronag commented Dec 27, 2020

@nodejs/streams

mcollina
mcollina approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/35100/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/35101/

lpinca
lpinca approved these changes Dec 28, 2020
View reviewed changes
test/parallel/test-stream-finished.js
Comment on lines +506 to +509
w.on('finish', () => {
assert.strictEqual(closed, false);
w.emit('aborted');
});
Copy link
Member

@lpinca lpinca Dec 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change
w.on('finish', () => {
assert.strictEqual(closed, false);
w.emit('aborted');
});
w.on('finish', common.mustCall(() => {
assert.strictEqual(closed, false);
w.emit('aborted');
}));

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2020

Landed in a5b43e9...faee739

@github-actions github-actions bot closed this Dec 30, 2020
nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2020
@ronag @nodejs-github-bot
stream: only use legacy close listeners if not willEmitClose
faee739 
Some streams that willEmitClose unecessarily fallback to legacy
events.

PR-URL: #36649
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@ronag @danielleadams
stream: only use legacy close listeners if not willEmitClose
190ddce 
Some streams that willEmitClose unecessarily fallback to legacy
events.

PR-URL: #36649
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@ronag @targos
stream: only use legacy close listeners if not willEmitClose
deb6f88 
Some streams that willEmitClose unecessarily fallback to legacy
events.

PR-URL: #36649
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@ronag @targos
stream: only use legacy close listeners if not willEmitClose
c101e37 
Some streams that willEmitClose unecessarily fallback to legacy
events.

PR-URL: #36649
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@ronag @targos
stream: only use legacy close listeners if not willEmitClose
ab130e9 
Some streams that willEmitClose unecessarily fallback to legacy
events.

PR-URL: #36649
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ronag @nodejs-github-bot @mcollina @Trott @benjamingr @lpinca