lib: refactor to use primordials in internal/priority_queue.js#36560
Closed
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Closed
lib: refactor to use primordials in internal/priority_queue.js#36560Lxxyx wants to merge 1 commit intonodejs:masterfrom
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Conversation
aduh95
approved these changes
Dec 18, 2020
Collaborator
PoojaDurgad
approved these changes
Dec 18, 2020
Collaborator
Member
Trott
approved these changes
Dec 23, 2020
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM assuming no significant performance degradation in the benchmark
Member
Author
|
Benchmark Result: |
Contributor
|
Another benchmark CI to see if there's consistent regression: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/802/ (queued) |
aduh95
approved these changes
Dec 25, 2020
Contributor
aduh95
left a comment
There was a problem hiding this comment.
No significant perf regressions, still LGTM
Contributor
|
Landed in 5d28edc...7303afb |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 25, 2020
PR-URL: #36560 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This comment has been minimized.
This comment has been minimized.
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36560 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36560 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36560 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36560 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Pooja D P <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes