doc: fix writable._construct() example#36509
Closed
mkbaranovskyi wants to merge 1 commit intonodejs:masterfrom
mkbaranovskyi:patch-1
Closed
doc: fix writable._construct() example#36509mkbaranovskyi wants to merge 1 commit intonodejs:masterfrom mkbaranovskyi:patch-1
writable._construct() example#36509mkbaranovskyi wants to merge 1 commit intonodejs:masterfrom
mkbaranovskyi:patch-1
Conversation
nodejs-github-bot
added
doc
aduh95
changed the title
writable._construct() ref example fixedwritable._construct() example
aduh95
approved these changes
Dec 14, 2020
Contributor
aduh95
left a comment
aduh95
left a comment
There was a problem hiding this comment.
Thank you for spotting this and sending a fix!
mscdex
changed the title
writable._construct() examplewritable._construct() example
jasnell
approved these changes
Dec 14, 2020
lpinca
approved these changes
Dec 14, 2020
Trott
approved these changes
Dec 18, 2020
ronag
approved these changes
Dec 18, 2020
Trott
pushed a commit
that referenced
this pull request
Dec 25, 2020
PR-URL: #36509 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Member
|
Landed in f441c8b. Thanks for the contribution! 🎉 |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36509 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request, please correct me if I'm missing something. The proposed changes include two small bug fixes in the
Streamreference, namely in the writable._construct() example:constructor- nofdparameter is passed. Instead,this.fdis appointed in the_construct()method. Removing this line from theconstructor()fixes the error.fs.open()callback parameters switched places according to the fs.open reference (and my tests).Checklist