test: specify global object for globals#36498
Conversation
Trott
added
request-ci
github-actions
bot
removed
the
request-ci
|
An additional change that might be good here is to add a comment explaining what externalizeString() and isOneByteString() do, as I believe these are the only places they appear in the Node.js code base (other than vendored-in code like the V8 source code). |
I could try to write something vague and hand-wave-y about string encoding and garbage collection, but I'd much rather have someone who knows what they're talking about it explain it. (As an added bonus, then I might understand it!) |
Be explicit about using `global.externalizeString()` etc. in test-fs-write instead of disabling the `no-undef` ESLint rule. PR-URL: nodejs#36498 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 44243e5 |
Be explicit about using `global.externalizeString()` etc. in test-fs-write instead of disabling the `no-undef` ESLint rule. PR-URL: #36498 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Be explicit about using `global.externalizeString()` etc. in test-fs-write instead of disabling the `no-undef` ESLint rule. PR-URL: #36498 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
4 participants
Be explicit about using
global.externalizeString()etc. intest-fs-write instead of disabling the
no-undefESLint rule.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes