stream: pipeline accept iterable as a valid first argument#36479
Closed
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Closed
stream: pipeline accept iterable as a valid first argument#36479Lxxyx wants to merge 1 commit intonodejs:masterfrom
Lxxyx wants to merge 1 commit intonodejs:masterfrom
Conversation
Lxxyx
changed the title
Lxxyx
force-pushed
the
fix-stream-pipeline-args
branch
from
90f1932 to
029bb0a
Compare
Lxxyx
force-pushed
the
fix-stream-pipeline-args
branch
from
029bb0a to
86d8a8f
Compare
jasnell
approved these changes
Dec 11, 2020
BridgeAR
approved these changes
Dec 11, 2020
ZYSzys
approved these changes
Dec 13, 2020
ZYSzys
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Trott
approved these changes
Dec 15, 2020
aduh95
approved these changes
Dec 15, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 45dbcbe...6837a6d |
BethGriggs
pushed a commit
that referenced
this pull request
Jan 19, 2021
Fixes: #36437 PR-URL: #36479 Backport-PR-URL: #36831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Jan 28, 2021
Fixes: #36437 PR-URL: #36479 Backport-PR-URL: #36831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #36437
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes(https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)