Documentation for how to unref readline#36458
Documentation for how to unref readline#36458vbinithyanandamv wants to merge 3 commits intonodejs:masterfrom
Conversation
Removed tab character and added 2 space
aduh95
left a comment
There was a problem hiding this comment.
Thanks for doing this. One minor nit:
As per suggestion. Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 updated. |
|
Reading through the readline docs, it seems this example may be lacking context. Could you add a sentence explaining the use-case and when it is useful? |
|
Welcome, @vbinithyanandamv and thanks for the pull request. I'm not sure this warrants its own section. Seems like it should go in the section of whatever call might result in requiring the |
|
@vbinithyanandamv Are you still planing on working on this? |
@vbinithyanandamv not any soon, you can take it up if you want to work on it. |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
#36154
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes