lib: restate the code to use primordials

[PoojaDurgad]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[aduh95]

The _http_common.js changes are already included in #36194.

[mscdex]

I don't understand why this change was made. Changing this from a function to a prototype object is changing the type entirely. Additionally, a function itself shouldn't ever need to be converted to any kind of primordial.

[aduh95]

TBF typeof Function.prototype === 'function', so it's not really changing the type.

[mscdex]

Interesting. Even so, I don't see the benefit of changing this unless someone can point to something specifically that this would be protecting us from?

[aduh95]

https://tc39.es/ecma262/#sec-properties-of-the-function-prototype-object

The Function prototype object:

• is itself a built-in function object.
• accepts any arguments and returns undefined when invoked.

It seems to be strictly equivalent to function noop(){}, the only difference I can think of is that it doesn't create a new Function object and may be marginally more memory efficient.
I highly doubt there is any scenario where it would show that Node is using one or the other, so I'm neutral to this change.

[ExE-Boss]

Well, it’s passed to setImmediate, which is obtained from require('timers') at the time the callback created by createOnGlobalUncaughtException is invoked, so if user code wraps setImmediate from timers, it can determine whether the passed function is %Function.prototype%.

[PoojaDurgad]

@mscdex ,@aduh95 - I made the changes based on this logic typeof Function.prototype === 'function' . Hence I modified the code. I am fine to revert this change, if others think it is not worth

[aduh95]

Closing based on performance concerns outlined in #38248.