lib(repl): add more primordials instead of builtin#36262
Closed
yashLadha wants to merge 1 commit intonodejs:masterfrom
Closed
lib(repl): add more primordials instead of builtin#36262yashLadha wants to merge 1 commit intonodejs:masterfrom
yashLadha wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
Hey, I was working on that in parallel in #36264, would you be interested in picking up the other changes I made in |
Contributor
Author
|
@aduh95 I think most of the things are already handled in your PR and my changes are just a subset of yours. I can pick your commits and see where I can contribute. |
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
|
@yashLadha should we close this? |
Contributor
Author
|
Yes I think we can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes