Closed
Conversation
Member
Author
|
@MylesBorins is this along the lines of what you had in mind? |
Member
|
Ironically, the commit message has insufficient context. Maybe this?: |
Trott
reviewed
Nov 22, 2020
Trott
reviewed
Nov 22, 2020
7 tasks
Trott
reviewed
Nov 25, 2020
Trott
reviewed
Nov 25, 2020
Trott
reviewed
Nov 25, 2020
doc/guides/technical-values.md
Outdated
Member
There was a problem hiding this comment.
I think either "will change" or "will evolve" is sufficient.
Trott
reviewed
Nov 25, 2020
Member
|
It would be helpful if the commit log / PR would contain more information about what the additional context is being added to :-) |
In the discussion of nodejs#35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com>
Member
Author
|
@jasnell updated |
Signed-off-by: Michael Dawson <mdawson@devrus.com>
Member
Author
|
@MylesBorins if you can take a look would be good to confirm the concern you had. |
Member
Author
|
@mmarchini any chance you can review/approve since you were in the meeting were we discussed as well? |
Trott
reviewed
Dec 4, 2020
Trott
reviewed
Dec 4, 2020
Trott
approved these changes
Dec 4, 2020
Co-authored-by: Rich Trott <rtrott@gmail.com>
Co-authored-by: Rich Trott <rtrott@gmail.com>
Member
Author
|
Linters have passed, landing |
mhdawson
added a commit
that referenced
this pull request
Dec 7, 2020
In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in 6d3775e |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 8, 2020
In the discussion of nodejs#35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Dec 21, 2020
In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
In the discussion of #35323 it was suggested that we should add some additional context/clarification to the technical values documented for the project. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #36201 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the discussion of #35323
it was suggested that we should add some
additional context/clarification.
Signed-off-by: Michael Dawson mdawson@devrus.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes