test: make test-http2-client-jsstream-destroy.js reliable#36129
Merged
Trott merged 1 commit intonodejs:masterfrom Nov 17, 2020
Merged
test: make test-http2-client-jsstream-destroy.js reliable#36129Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
Member
Author
|
@mmomtchev Can you confirm that this still tests the thing you intended it to test? |
aduh95
approved these changes
Nov 15, 2020
benjamingr
approved these changes
Nov 16, 2020
Contributor
|
@Trott It has the downside of blocking indefinitely on the old version, but otherwise yes, iit does test it |
mmomtchev
reviewed
Nov 16, 2020
Member
Author
Ah, OK. We have a lot of tests that are like that so I think I'm OK leaving it that way. |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
Use events instead of setTimeout() calls. Fixes: nodejs#36078 PR-URL: nodejs#36129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Member
Author
|
Landed in fff25a0 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use events instead of setTimeout() calls.
Fixes: #36078
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes