tools: hide commit queue action link#36124
Closed
aduh95 wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
lundibundi
approved these changes
Nov 15, 2020
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Trott
approved these changes
Nov 15, 2020
Collaborator
lpinca
approved these changes
Nov 15, 2020
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 88d0b5b...08be03b |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 17, 2020
PR-URL: #36124 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Nov 22, 2020
PR-URL: #36124 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 9, 2020
PR-URL: #36124 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
PR-URL: #36124 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
PR-URL: #36124 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it's useful to have it outside of the
<details>element – folks who are likely to click on it are also likely to open the<details>first, and it takes place for folks who are not interested.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes