Conversation
|
LGTM, though I think io.js looks nicer as |
|
@Fishrock123 done ^^ |
kevinohara80
changed the title
|
"io.js" isn't a programatic name so I'm -1 on |
rvagg
force-pushed
the
v0.12
branch
4 times, most recently
from
d7e65ff to
185d11c
Compare
|
Yeah Rod is correct, I'm just silly. |
|
@rvagg I just removed the back ticks. Agree that formatting should be reserved for programatic items. |
|
@Fishrock123 @rvagg are we good with this? |
|
sure, the line breaks bother me but that's not a big deal LGTM |
|
I think this needs to be rebased anyway before it can be applied. @kevinohara80 If you could fix the line breaks while you are at it, that would be great. |
|
No problem. I'll do this today. On Wednesday, Dec 10, 2014 at 7:43 AM, Ben Noordhuis [email protected], wrote: I think this needs to be rebased anyway before it can be applied. @kevinohara80 If you could fix the line breaks while you are at it, that would be great. — |
|
@bnoordhuis @rvagg Rebased and removed whitespace to make it a single paragraph. Let me know if there's any other tweaks. |
|
Sorry, I didn't notice it's spread out over multiple commits. Can you squash them and make the commit log conform to what is outlined in CONTRIBUTING.md? |
rewords project messaging in README to make the overall project messaging a bit clearer. More discussion to be found in nodejs#24
|
@bnoordhuis My bad. Does this look good? |
Rewords project messaging in README to make the overall project messaging a bit clearer. More discussion to be found in #24. PR-URL: #36 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
Looks great, Kevin. Landed in 6f1d0a8, thanks! |
7 participants
The previous paragraph was good but a little unclear. This fixes that.