http2: Fix error stream write followed by destroy by davedoesdev · Pull Request #35951 · nodejs/node

davedoesdev · 2020-11-04T00:18:03Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Without the fix, the test fails with:

node:internal/http2/core:179
  debugStream(stream[kID], stream[kSession][kType], message, ...args);
                                           ^

TypeError: Cannot read property 'Symbol(type)' of undefined
    at debugStreamObj (node:internal/http2/core:179:44)
    at node:internal/http2/core:2041:7
    at processTicksAndRejections (node:internal/process/task_queues:75:11)

nodejs-github-bot · 2020-11-04T00:18:07Z

Review requested:

@nodejs/http2
@nodejs/net

mcollina

lgtm

rickyes · 2020-11-05T05:07:10Z

test/parallel/test-http2-destroy-after-write.js

Suggested change

session.on('stream', function(stream) {

session.on('stream', common.mustCall(function(stream) {

rickyes · 2020-11-05T05:07:42Z

test/parallel/test-http2-destroy-after-write.js

Suggested change

server.on('session', function(session) {

server.on('session', common.mustCall(function(session) {

nodejs-github-bot · 2020-11-05T08:53:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34074/

nodejs-github-bot · 2020-11-05T10:52:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34075/

nodejs-github-bot · 2020-11-05T14:19:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34084/

mcollina · 2020-11-05T16:40:37Z

There seems to be a problem on ARM :(

davedoesdev · 2020-11-05T22:43:38Z

There seems to be a problem on ARM :(

14:22:04 + git checkout -f refs/remotes/jenkins_tmp
14:22:04 fatal: Unable to create '/home/iojs/build/workspace/node-test-binary-arm/.git/index.lock': File exists.
14:22:04 
14:22:04 Another git process seems to be running in this repository,
...
14:22:07 mkdir: cannot create directory ‘out/junit’: No such file or directory

nodejs-github-bot · 2020-11-06T00:04:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34112/ ✅

richardlau · 2020-11-06T00:04:39Z

There seems to be a problem on ARM :(

14:22:04 + git checkout -f refs/remotes/jenkins_tmp
14:22:04 fatal: Unable to create '/home/iojs/build/workspace/node-test-binary-arm/.git/index.lock': File exists.
14:22:04 
14:22:04 Another git process seems to be running in this repository,
...
14:22:07 mkdir: cannot create directory ‘out/junit’: No such file or directory

Should have been fixed by nodejs/build#2475, I've resumed the last CI run.

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott · 2020-11-06T13:39:21Z

Landed in 1fd7d8e

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

nodejs-github-bot added the http2 Issues or PRs related to the http2 subsystem. label Nov 4, 2020

crypt096 approved these changes Nov 4, 2020

View reviewed changes

mcollina approved these changes Nov 4, 2020

View reviewed changes

rickyes approved these changes Nov 5, 2020

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 5, 2020

Trott approved these changes Nov 5, 2020

View reviewed changes

http2: fix error stream write followed by destroy

1fd7d8e

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott merged commit 1fd7d8e into nodejs:master Nov 6, 2020

danielleadams pushed a commit that referenced this pull request Nov 9, 2020

http2: fix error stream write followed by destroy

1dd744a

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams mentioned this pull request Nov 9, 2020

v15.2.0 proposal #36055

Merged

BethGriggs pushed a commit that referenced this pull request Dec 9, 2020

http2: fix error stream write followed by destroy

b03ea21

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request Dec 10, 2020

http2: fix error stream write followed by destroy

1a520e5

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs mentioned this pull request Dec 10, 2020

v14.15.2 proposal #36476

Merged

BethGriggs pushed a commit that referenced this pull request Dec 15, 2020

http2: fix error stream write followed by destroy

92bd7b5

PR-URL: #35951 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

http2: Fix error stream write followed by destroy#35951

http2: Fix error stream write followed by destroy#35951
Trott merged 1 commit intonodejs:masterfrom
davedoesdev:fix-http2-destroy-after-write

davedoesdev commented Nov 4, 2020

Uh oh!

nodejs-github-bot commented Nov 4, 2020

Uh oh!

mcollina left a comment

Uh oh!

rickyes Nov 5, 2020

Uh oh!

rickyes Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 5, 2020

Uh oh!

mcollina commented Nov 5, 2020

Uh oh!

davedoesdev commented Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 6, 2020 •

edited by Trott

Loading

Uh oh!

richardlau commented Nov 6, 2020

Uh oh!

Trott commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

	session.on('stream', function(stream) {
	session.on('stream', common.mustCall(function(stream) {

	server.on('session', function(session) {
	server.on('session', common.mustCall(function(session) {

Uh oh!

Conversation

davedoesdev commented Nov 4, 2020

Checklist

Uh oh!

nodejs-github-bot commented Nov 4, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

rickyes Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

rickyes Nov 5, 2020

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 5, 2020

Uh oh!

mcollina commented Nov 5, 2020

Uh oh!

davedoesdev commented Nov 5, 2020

Uh oh!

nodejs-github-bot commented Nov 6, 2020 • edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Nov 6, 2020

Uh oh!

Trott commented Nov 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nodejs-github-bot commented Nov 6, 2020 •

edited by Trott

Loading