stream: remove isPromise utility function#35925
Closed
aduh95 wants to merge 2 commits intonodejs:masterfrom
Closed
stream: remove isPromise utility function#35925aduh95 wants to merge 2 commits intonodejs:masterfrom
aduh95 wants to merge 2 commits intonodejs:masterfrom
Conversation
Collaborator
|
Review requested:
|
ronag
requested changes
Nov 2, 2020
Contributor
Author
|
Yes the behavior is the same. Another way would be to change the name of the function |
Member
|
Actually the current implementation (and the one in this PR) is wrong if someone passes a It's not a big bug but promise test suites check for it. The correct implementation would be to do it in "two steps":
See here for an example |
ronag
added a commit
to nodejs/undici
that referenced
this pull request
Nov 2, 2020
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once.
aduh95
force-pushed
the
stream-remove-isPromise
branch
from
35e4d0a to
f18db47
Compare
Contributor
Author
|
I've implemented the solution suggested by @benjamingr, PTAL. |
benjamingr
approved these changes
Nov 2, 2020
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
Please consider adding a test.
If you prefer not to - I'll add one sometime after this lands :]
Contributor
Author
|
Test added! It does fail on master and not with this PR, PTAL. @ronag Have your concerns been addressed? |
Contributor
Author
|
@ronag are you still blocking this or can your objection be dismissed? |
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
ronag
approved these changes
Nov 8, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
mcollina
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in adae822...ad98cf0 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Nov 9, 2020
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once. PR-URL: #35925 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Nov 9, 2020
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once. PR-URL: #35925 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The function was not checking if the parameter was actually a Promise instance, but if it has a `then` method. Removing the utility function in favor of a clearer `typeof` check, handling the case when the thenable throws if then method is accessed more than once. PR-URL: #35925 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function was not checking if the parameter was actually a Promise
instance, but if it has a
thenmethod. Removing the utility functionin favor of a clearer
typeofcheck, handling the case when thethenable throws if then method is accessed more than once.
The difference between a thenable and a
Promisemay be important when using third party library (the parameter is provided by the user) and/or whenPromise.prototype.thenvalue is changed from userland.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes