docs: update crypto.createSecretKey history#35874
Merged
Trott merged 1 commit intonodejs:masterfrom Nov 1, 2020
Merged
Conversation
nodejs-github-bot
added
crypto
Trott
approved these changes
Oct 29, 2020
tniessen
approved these changes
Nov 1, 2020
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
I guess we'll never get rid of strings as keys :(
Passing strings to `crypto.createSecretKey` was not added until v15.0.0 (specifically with commit dae283d). The existing documentation implies its availability in prior versions which may cause confusion. PR-URL: nodejs#35874 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Member
|
Landed in 09af8c8. Thanks for the contribution! 🎉 |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
Passing strings to `crypto.createSecretKey` was not added until v15.0.0 (specifically with commit dae283d). The existing documentation implies its availability in prior versions which may cause confusion. PR-URL: #35874 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing strings to
crypto.createSecretKeywas not added until v15.0.0(specifically with commit dae283d). The existing documentation implies its
availability in prior versions which may cause confusion.
Checklist