Closed
Conversation
gireeshpunathil
approved these changes
Oct 24, 2020
Trott
approved these changes
Oct 24, 2020
Trott
approved these changes
Oct 24, 2020
aduh95
added
the
author ready
aduh95
approved these changes
Oct 24, 2020
lpinca
approved these changes
Oct 24, 2020
juanarbol
approved these changes
Oct 26, 2020
watilde
approved these changes
Oct 26, 2020
rickyes
added
the
commit-queue
rickyes
approved these changes
Oct 26, 2020
github-actions
bot
added
commit-queue-failed
Contributor
Commit Queue failed- Loading data for nodejs/node/pull/35786 ✔ Done loading data for nodejs/node/pull/35786 ----------------------------------- PR info ------------------------------------ Title doc: fix a typo in CHANGELOG_V12 (#35786) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch iShibi:patch-1 -> nodejs:master Labels author ready, doc Commits 1 - doc: fix a typo in CHANGELOG_V12 Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/35786 Reviewed-By: Gireesh Punathil Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Juan José Arboleda Reviewed-By: Daijiro Wachi Reviewed-By: Ricky Zhou <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/35786 Reviewed-By: Gireesh Punathil Reviewed-By: Rich Trott Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca Reviewed-By: Juan José Arboleda Reviewed-By: Daijiro Wachi Reviewed-By: Ricky Zhou <[email protected]> -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Sat, 24 Oct 2020 09:25:39 GMT ✔ Approvals: 7 ✔ - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/35786#pullrequestreview-516268519 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/35786#pullrequestreview-516274890 ✔ - Antoine du Hamel (@aduh95): https://github.com/nodejs/node/pull/35786#pullrequestreview-516281499 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/35786#pullrequestreview-516300789 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/35786#pullrequestreview-516417042 ✔ - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/35786#pullrequestreview-516418806 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/35786#pullrequestreview-516428642 ✖ This PR needs to wait 7 more hours to land -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu Commit Queue action: https://github.com/nodejs/node/actions/runs/328156544 |
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 26, 2020
PR-URL: #35786 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
Member
|
landed in e2d2206 , thanks for the contribution! |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35786 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
targos
removed
the
commit-queue-failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes