Merged
Conversation
PR-URL: #35585 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Use kbd element for key strokes and remove extra parentheses. PR-URL: #35656 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
PR-URL: #35693 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Add Danielle Adams's release key. PR-URL: #35545 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Signed-off-by: James M Snell <[email protected]> Fixes: #35722 PR-URL: #35723 Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
BethGriggs
added a commit
that referenced
this pull request
Oct 21, 2020
BethGriggs
force-pushed
the
v15.0.1-proposal
branch
from
b94e07b to
f7abd6a
Compare
github-actions
bot
removed
the
request-ci
targos
approved these changes
Oct 21, 2020
Trott
approved these changes
Oct 21, 2020
gengjiawen
approved these changes
Oct 21, 2020
gireeshpunathil
approved these changes
Oct 21, 2020
Contributor
|
Would be great to pull this #35732 in ➰ |
Codecov Report
@@ Coverage Diff @@
## v15.x #35736 +/- ##
========================================
Coverage ? 96.40%
========================================
Files ? 220
Lines ? 73676
Branches ? 0
========================================
Hits ? 71026
Misses ? 2650
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
|
If possible can we include the npm update? |
PR-URL: #35698 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #35707 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This commit sets the OpenSSL error mark before calling X509_STORE_load_locations and pops the error mark afterwards. The motivation for this is that it is possible that X509_STORE_load_locations can produce errors if the configuration option --openssl-system-ca-path file does not exist. Later if a different function is called which calls an OpenSSL function it could fail because these errors might still be on the OpenSSL error stack. Currently, all functions that call NewRootCertStore clear the OpenSSL error queue upon returning, but this was not the case for example in v12.18.0. PR-URL: #35514 Fixes: #35456 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils. PR-URL: #35732 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
BethGriggs
force-pushed
the
v15.0.1-proposal
branch
from
f7abd6a to
a84aedc
Compare
PR-URL: #35724 Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Rich Trott <[email protected]>
BethGriggs
force-pushed
the
v15.0.1-proposal
branch
from
a84aedc to
0c5dbc1
Compare
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
richardlau
requested changes
Oct 21, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
There should be a link to 15.0.1 in the TOC of CHANGELOG_V15.md.
BethGriggs
force-pushed
the
v15.0.1-proposal
branch
from
0c5dbc1 to
8451c4a
Compare
richardlau
approved these changes
Oct 21, 2020
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Oct 21, 2020
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Oct 21, 2020
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Oct 21, 2020
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2020-10-21, Version 15.0.1 (Current), @BethGriggs
Notable changes
Commits
c509485c19] - build: use make functions instead of echo (Antoine du Hamel) #35707f5acc2d030] - crypto: fix regression on randomFillSync (James M Snell) #35723595c8df48d] - deps: upgrade npm to 7.0.3 (Ruy Adorno) #3572469e7f20f2d] - deps: V8: set correct V8 version patch number (Michaël Zasso) #35732b78294dc00] - doc: use kbd element in readline doc (Rich Trott) #356981efa87082b] - doc: add release key for Danielle Adams (Danielle Adams) #355456e91d644e3] - doc: use kbd element in os doc (Rich Trott) #356565a48a7b6f8] - doc: add a statement in the documentation. (Pooja D.P) #355856a7a61be7c] - src: mark/pop OpenSSL errors in NewRootCertStore (Daniel Bevenius) #35514d54edece99] - test: refactor test-crypto-pbkdf2 (Tobias Nießen) #35693