Conversation
nodejs-github-bot
added
build
Codecov Report
@@ Coverage Diff @@
## master #35710 +/- ##
==========================================
+ Coverage 96.40% 96.41% +0.01%
==========================================
Files 220 220
Lines 73675 73675
==========================================
+ Hits 71025 71033 +8
+ Misses 2650 2642 -8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
The first commit message needs to be more descriptive. The subsequent commit message should be a "fixup" commit message or else squashed into the first. Otherwise, the bot will land it as a separate commit.
The content is might not be in the best place. It separates the macos firewall tool from Running Tests and those two things should go together. I think it's fine (better even?) for the install instructions to be located where they were before.
Since the commit message needed only a small tweak, I rebased, squashed, and force-pushed. I hope I didn't mess up your workflow, and if I did, I apologize in advance! |
Having second thoughts about my comment here. Maybe it's fine where it is. And if not, we can move it some other time. Sorry to leave a wall of comments and then walk back half of them. |
|
@Trott - no problem. thanks |
PR-URL: nodejs#35710 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
|
Landed in 1ba932b |
PR-URL: #35710 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35710 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35710 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #35710 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]>
6 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes