http2: remove unsupported %.* specifier#35694
Closed
mmomtchev wants to merge 1 commit intonodejs:masterfrom
Closed
http2: remove unsupported %.* specifier#35694mmomtchev wants to merge 1 commit intonodejs:masterfrom
mmomtchev wants to merge 1 commit intonodejs:masterfrom
Conversation
The debug sprintf doesn't support %.* specifiers Fixes: nodejs#35688
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report
@@ Coverage Diff @@
## master #35694 +/- ##
=======================================
Coverage 96.40% 96.40%
=======================================
Files 220 220
Lines 73681 73681
=======================================
+ Hits 71031 71032 +1
+ Misses 2650 2649 -1
Continue to review full report at Codecov.
|
Contributor
|
Are we sure this is safe? According to the documentation (emphasis mine):
|
Member
|
Non-blocking naive questions: Can we/should we add a test? A lint rule? An assertion or other check/confirmation of NULL-termination? |
Member
I would not add a test for specific debugging statements.
That would be great, but it might be quite a bit of effort.
I don’t see any issue with adding |
fhinkel
approved these changes
Oct 19, 2020
Trott
approved these changes
Oct 19, 2020
rickyes
approved these changes
Oct 20, 2020
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
devnexen
approved these changes
Oct 20, 2020
devnexen
added
the
author ready
aduh95
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in c5b9b5b...7083425 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 24, 2020
The debug sprintf doesn't support %.* specifiers Fixes: #35688 PR-URL: #35694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
The debug sprintf doesn't support %.* specifiers Fixes: #35688 PR-URL: #35694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
The debug sprintf doesn't support %.* specifiers Fixes: #35688 PR-URL: #35694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
The debug sprintf doesn't support %.* specifiers Fixes: #35688 PR-URL: #35694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
The debug sprintf doesn't support %.* specifiers Fixes: #35688 PR-URL: #35694 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug sprintf doesn't support %.* specifiers
Fixes: #35688
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes