doc: improve text for breakOnSigint#35692
Merged
Trott merged 1 commit intonodejs:masterfrom Oct 24, 2020
Merged
Conversation
nodejs-github-bot
added
doc
Trott
commented
Oct 17, 2020
doc/api/vm.md
Outdated
Member
Author
There was a problem hiding this comment.
The word interrupted here is the one thing I didn't modify for consistency. The other six instances say terminated. I wasn't completely sure the choice wasn't intentional or which word was better than the other. @nodejs/vm @nodejs/documentation
Member
There was a problem hiding this comment.
I think interrupt is a good word, especially given that that’s what SIGINT stands for :)
Contributor
There was a problem hiding this comment.
Should it be interrupted on the other six instances then? I think consistency would be good, and @addaleax makes a good point.
Member
Author
There was a problem hiding this comment.
Should it be
interruptedon the other six instances then?
I'll land this as-is and open a follow-on PR about that.
Member
Author
|
Before:
After:
|
lpinca
approved these changes
Oct 18, 2020
randomhash
approved these changes
Oct 19, 2020
aymen94
approved these changes
Oct 19, 2020
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: nodejs#35692 Reviewed-By: Luigi Pinca <[email protected]>
Member
Author
|
Landed in 6bf2139 |
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: #35692 Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 8, 2020
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: #35692 Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Dec 10, 2020
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: #35692 Reviewed-By: Luigi Pinca <[email protected]>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Dec 15, 2020
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: #35692 Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist