Skip to content

[v12.x backport] http: only set keep-alive when not exists#35623

Closed
atian25 wants to merge 1 commit intonodejs:v12.x-stagingfrom
atian25:backport-35138-to-v12.x
Closed

[v12.x backport] http: only set keep-alive when not exists#35623
atian25 wants to merge 1 commit intonodejs:v12.x-stagingfrom
atian25:backport-35138-to-v12.x

Conversation

@atian25
Copy link
Contributor

@atian25 atian25 commented Oct 13, 2020

Backport-PR-URL: #35138

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2020

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v12.x labels Oct 13, 2020
@atian25 atian25 mentioned this pull request Oct 13, 2020
Closed
4 tasks
rickyes
rickyes approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33558/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 13, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 13, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33568/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 14, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33605/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 15, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33633/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 15, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 15, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33638/ ✅

@atian25 atian25 mentioned this pull request Oct 19, 2020
Merged
4 tasks
@rickyes rickyes added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 28, 2020
@rickyes
Copy link
Contributor

rickyes commented Oct 28, 2020

@nodejs/releasers Sorry, do we have a firm date for the next v12 release?

@BethGriggs
Copy link
Member

BethGriggs commented Oct 29, 2020

@rickyes, we try to schedule our dates in nodejs/Release#494 (draft, pending releaser availability). The next one that we have volunteers for is v12.20.0 on 2020-11-17 - so this PR should go out in v12.20.0.

MylesBorins pushed a commit that referenced this pull request Nov 3, 2020
@atian25 @MylesBorins
http: only set keep-alive when not exists
ff3875d 
Backport-PR-URL: #35623
PR-URL: #35138
Fixes: #34561
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@MylesBorins
Copy link
Contributor

MylesBorins commented Nov 3, 2020

landed in ff3875d

@MylesBorins MylesBorins closed this Nov 3, 2020
MylesBorins pushed a commit that referenced this pull request Nov 16, 2020
@atian25 @MylesBorins
http: only set keep-alive when not exists
d477e2e 
Backport-PR-URL: #35623
PR-URL: #35138
Fixes: #34561
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rickyes rickyes rickyes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atian25 @nodejs-github-bot @rickyes @BethGriggs @MylesBorins