Reforming process.ppid API docs property in the process.md#35589
Merged
Trott merged 1 commit intonodejs:masterfrom Oct 13, 2020
Merged
Reforming process.ppid API docs property in the process.md#35589Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
PoojaDurgad
changed the title
addaleax
approved these changes
Oct 10, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Maybe we could also link to the getppid(2) man page? It might be worth giving a resource that describes the behavior when e.g. the original parent process has already terminated.
Trott
reviewed
Oct 11, 2020
doc/api/process.md
Outdated
Member
There was a problem hiding this comment.
Suggested change
| The `process.ppid` property returns the PID of the parent of the | |
| The `process.ppid` property returns the PID of the parent of the |
FYI, if you run make lint-md on your changes, it will report these sorts of lint issues in the .md files.
Contributor
Author
There was a problem hiding this comment.
@Trott - Thanks for the suggestion. lint issue is fixed. Please have a look.
Trott
approved these changes
Oct 11, 2020
PoojaDurgad
force-pushed
the
process-ppid
branch
2 times, most recently
from
7a3095d to
8e8d649
Compare
jasnell
approved these changes
Oct 13, 2020
PR-URL: nodejs#35589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
force-pushed
the
process-ppid
branch
2 times, most recently
from
c072d80 to
dcf708d
Compare
Member
|
Landed in dcf708d |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35589 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes