[v12.x backport] stream: destroy wrapped streams on error#35557
Closed
lpinca wants to merge 1 commit intonodejs:v12.x-stagingfrom
Closed
[v12.x backport] stream: destroy wrapped streams on error#35557lpinca wants to merge 1 commit intonodejs:v12.x-stagingfrom
lpinca wants to merge 1 commit intonodejs:v12.x-stagingfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
stream
Member
Author
|
cc: @ronag |
ronag
approved these changes
Oct 8, 2020
Member
Author
|
The test fails, I guess this depends on something else. |
ronag
reviewed
Oct 8, 2020
ronag
reviewed
Oct 8, 2020
Member
Author
|
Adapted to v12.x |
ronag
approved these changes
Oct 8, 2020
Member
Author
|
The problem was that the same |
Member
You could change the test to allow it being emitted twice. |
Member
Author
|
I found a better fix. |
lpinca
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Stream should be destroyed and update state accordingly when the wrapped stream emits error. Does some additional cleanup with future TODOs that might be worth looking into. PR-URL: nodejs#34102 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
lpinca
force-pushed
the
backport-34102-to-v12.x
branch
from
55949b6 to
4afe946
Compare
3 tasks
benjamingr
approved these changes
Oct 9, 2020
ronag
approved these changes
Oct 9, 2020
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Oct 12, 2020
Prevent multiple listeners for the `'error'` event to be added to the same `EventEmitter` instance. PR-URL: nodejs#35560 Refs: nodejs#35557 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
Prevent multiple listeners for the `'error'` event to be added to the same `EventEmitter` instance. PR-URL: #35560 Refs: #35557 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
Stream should be destroyed and update state accordingly when the wrapped stream emits error. Does some additional cleanup with future TODOs that might be worth looking into. Backport-PR-URL: #35557 PR-URL: #34102 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Contributor
|
landed in e40b78c |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
Stream should be destroyed and update state accordingly when the wrapped stream emits error. Does some additional cleanup with future TODOs that might be worth looking into. Backport-PR-URL: #35557 PR-URL: #34102 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Prevent multiple listeners for the `'error'` event to be added to the same `EventEmitter` instance. PR-URL: nodejs#35560 Refs: nodejs#35557 (comment) Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stream should be destroyed and update state accordingly when
the wrapped stream emits error.
Does some additional cleanup with future TODOs that might be worth
looking into.
PR-URL: #34102
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes