doc: document Buffer.concat may use internal pool#35541
Closed
puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
Closed
doc: document Buffer.concat may use internal pool#35541puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
puzpuzpuz wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
buffer
lpinca
approved these changes
Oct 7, 2020
addaleax
approved these changes
Oct 7, 2020
HarshithaKP
approved these changes
Oct 8, 2020
Trott
approved these changes
Oct 8, 2020
puzpuzpuz
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
@addaleax isn't this behavior problematic for |
Member
Member
|
Yes and no. Should be fine in regards to the problem I was worried about. What's unfortunate is that there is no way to not use the pool when concatenating if I know that might cause problems or reduced performance (e.g. transferList). But maybe that is just a nit. |
Member
Author
Users may decide to implement their own concat method which doesn't use the pool. Alternatively, we could introduce As for this very PR, it simply describes what we have now. |
Member
Yes, sorry for going off-topic. |
ronag
approved these changes
Oct 13, 2020
Collaborator
Collaborator
Collaborator
Collaborator
puzpuzpuz
added a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35541 Refs: #32703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Member
Author
|
Landed in ef1645e |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 14, 2020
PR-URL: #35541 Refs: #32703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #35541 Refs: #32703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #35541 Refs: #32703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35541 Refs: nodejs#32703 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Harshitha K P <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Robert Nagy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #32703
The documentation was silent about the fact that
Buffer.concat()usesBuffer.allocaUnsafe()and, thus, may return pooled buffers. This PR fixes that.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes