modules: add setter for module.parent by aduh95 · Pull Request #35522 · nodejs/node

aduh95 · 2020-10-06T15:57:59Z

module.parent breaks the ecosystem when read-only (see #32217 (comment)). This PR adds a setter to allow user to change its value instead of throwing.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2020-10-06T15:58:03Z

Review requested:

@nodejs/modules

richardlau · 2020-10-06T16:03:33Z

CITGM: https://ci.nodejs.org/job/citgm-smoker/2498/

bmeck

LGTM pending lint

richardlau

From the CITGM results that have completed this has fixed the node-gyp test suite, thanks.

richardlau · 2020-10-06T17:55:18Z

Can we fast track? Would be good to get this in the next 14.x release

14.x isn't affected. #33533 didn't backport the breaking parts of #32217.

nodejs-github-bot · 2020-10-06T17:56:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33430/

aduh95 · 2020-10-06T17:56:51Z

BTW, this should have the label dont-land-on-v14.x and dont-land-on-v12.x.

ExE-Boss · 2020-10-07T18:06:32Z

My only issue with converting module.parent into an accessor on the prototype is that delete module.parent no longer works (unless module is converted into a Proxy) and module.parent = undefined triggers the deprecation warning.

bmeck · 2020-10-08T14:35:14Z

lib/internal/modules/cjs/loader.js

Make delete work:

Suggested change

) : setModuleParent,

) : setModuleParent,

configurable: true,

bmeck · 2020-10-08T14:35:35Z

@ExE-Boss making the property configurable should make delete work.

bmeck · 2020-10-08T14:40:24Z

test/parallel/test-module-parent-setter-deprecation.js

Suggested change

module.parent = undefined;

module.parent = undefined;

delete module.parent;

assert.strictEqual('parent' in module, false);

bmeck · 2020-10-08T14:40:42Z

test/parallel/test-module-parent-setter-deprecation.js

Suggested change

const common = require('../common');

const common = require('../common');

const assert = require('assert');

bmeck · 2020-10-08T14:41:34Z

lib/internal/modules/cjs/loader.js

moving this to be on the module itself is needed to make delete work

Wouldn't that trigger a new deprecation warning for each Module instance?

module.parent; // triggers one warning module.parent?.parent; // triggers another warning?

No, because the deprecation uses a deprecation code:

node/lib/internal/util.js

Lines 77 to 82 in ce84bac

if (code !== undefined) {

if (!codesWarned.has(code)) {

process.emitWarning(msg, 'DeprecationWarning', code, deprecated);

codesWarned.add(code);

}

} else {

aduh95 · 2020-10-13T13:36:55Z

@ExE-Boss Would it be fine for you if we land this PR as is, and then someone else (maybe you?) opens another PR with the changes you're suggesting? I'm afraid I don't have the bandwidth to work on this currently, and I wouldn't want it to miss the v15.x release.

ExE-Boss · 2020-10-13T18:11:04Z

@aduh95 I don’t mind either way.

PR-URL: nodejs#35522 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

aduh95 · 2020-10-16T22:51:23Z

Landed in aaf225a

hybrist approved these changes Oct 6, 2020

View reviewed changes

bmeck approved these changes Oct 6, 2020

View reviewed changes

richardlau approved these changes Oct 6, 2020

View reviewed changes

aduh95 force-pushed the module-parent-setter branch from 137222b to 80384e8 Compare October 6, 2020 17:08

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020

This comment has been minimized.

Sign in to view

MylesBorins added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2020

richardlau added dont-land-on-v12.x labels Oct 6, 2020

MylesBorins removed the fast-track PRs that do not need to wait for 48 hours to land. label Oct 6, 2020

This comment has been minimized.

Sign in to view

ryzokuken approved these changes Oct 6, 2020

View reviewed changes

benjamingr approved these changes Oct 6, 2020

View reviewed changes

addaleax approved these changes Oct 7, 2020

View reviewed changes

bmeck reviewed Oct 8, 2020

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 14, 2020

aduh95 force-pushed the module-parent-setter branch from 80384e8 to aaf225a Compare October 16, 2020 22:51

aduh95 merged commit aaf225a into nodejs:master Oct 16, 2020

aduh95 deleted the module-parent-setter branch October 16, 2020 22:51

-module.parent = undefined;
+module.parent = undefined;
+delete module.parent;
+assert.strictEqual('parent' in module, false);

	const common = require('../common');
	const common = require('../common');
	const assert = require('assert');

	if (code !== undefined) {
	if (!codesWarned.has(code)) {
	process.emitWarning(msg, 'DeprecationWarning', code, deprecated);
	codesWarned.add(code);
	}
	} else {

Uh oh!

Conversation

aduh95 commented Oct 6, 2020

Checklist

Uh oh!

nodejs-github-bot commented Oct 6, 2020

Uh oh!

richardlau commented Oct 6, 2020

Uh oh!

bmeck left a comment

Choose a reason for hiding this comment

Uh oh!

richardlau left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

richardlau commented Oct 6, 2020

Uh oh!

nodejs-github-bot commented Oct 6, 2020

Uh oh!

aduh95 commented Oct 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

ExE-Boss commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmeck Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

bmeck commented Oct 8, 2020

Uh oh!

bmeck Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

bmeck Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

bmeck Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

aduh95 Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

ExE-Boss Oct 8, 2020

Choose a reason for hiding this comment

Uh oh!

aduh95 commented Oct 13, 2020

Uh oh!

ExE-Boss commented Oct 13, 2020

Uh oh!

aduh95 commented Oct 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

aduh95 commented Oct 6, 2020 •

edited

Loading

ExE-Boss commented Oct 7, 2020 •

edited

Loading