doc: outline when origin is set to unhandledRejection#35294
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 29, 2020
Merged
doc: outline when origin is set to unhandledRejection#35294Trott merged 1 commit intonodejs:masterfrom
Trott merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
richardlau
approved these changes
Sep 22, 2020
BridgeAR
reviewed
Sep 22, 2020
Member
BridgeAR
left a comment
BridgeAR
left a comment
There was a problem hiding this comment.
We added another mode that is not yet documented either. It would be great to add that as well :-)
Member
|
@mlarcher thanks for opening the PR to fix this! |
mlarcher
force-pushed
the
master
branch
2 times, most recently
from
98f2b33 to
70f769f
Compare
lundibundi
approved these changes
Sep 22, 2020
Contributor
Author
|
what's next ? is there something required on my part or one of the approver just has to merge the PR ? |
Contributor
|
@mlarcher nothing else required from your part. We have a minimum wait time of 48h before landing any PRs, so it should be landed tomorrow (or afterwards, depending on collaborators availability) |
Contributor
Author
|
ok, thanks for the info mary :) |
Trott
approved these changes
Sep 29, 2020
PR-URL: nodejs#35294 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 1390574. Thanks for the contribution! 🎉 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 29, 2020
PR-URL: #35294 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35294 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Add a line about
unhandledRejectionin the doc foruncaughtExceptionMonitorto make it clear thatuncaughtExceptionMonitorwill only called for an unhandled promise rejection if--unhandled-rejectionsflag is set to "strict".This addition is a copy and paste from the doc about uncaughtException, as both have the same behaviour on the matter.
This MR was initiated because of the issue #35291