[v12.x backport] async_hooks: fix resource stack for deep stacks#35287
Closed
johanneswuerbach wants to merge 1 commit intonodejs:v12.x-stagingfrom
Closed
[v12.x backport] async_hooks: fix resource stack for deep stacks#35287johanneswuerbach wants to merge 1 commit intonodejs:v12.x-stagingfrom
johanneswuerbach wants to merge 1 commit intonodejs:v12.x-stagingfrom
Conversation
460c81d introduced a bug where the execution resource was not stored properly if we needed to call into C++ to extend the stack size. Fix that bug by always storing the resource. Refs: nodejs#34319 Fixes: nodejs#34556 PR-URL: nodejs#34573 Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Gus Caplan <me@gus.host>
nodejs-github-bot
added
async_hooks
Member
addaleax
force-pushed
the
v12.x-staging
branch
4 times, most recently
from
55fe022 to
65b7bf4
Compare
Member
|
These commits have been landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport for #34573
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes