doc: add socket.readyState#35262
Merged
Trott merged 1 commit intonodejs:masterfrom Sep 23, 2020
clarkkozak:net-doc-readyState
Merged
doc: add socket.readyState#35262Trott merged 1 commit intonodejs:masterfrom clarkkozak:net-doc-readyState
socket.readyState#35262Trott merged 1 commit intonodejs:masterfrom
clarkkozak:net-doc-readyState
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
Contributor
Author
|
Also it is still in the current version of Node: Line 524 in c66e647 |
Contributor
Author
|
I'm unsure on how to add it to the navigation properly. If someone can advise on how to do so that would be awesome. |
addaleax
approved these changes
Sep 20, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
This will automatically be added to the table of contents, nothing to take care of there :)
Contributor
Author
Right on! Thank you! |
Trott
approved these changes
Sep 23, 2020
Member
|
Landed in 81379d1. Thanks for the contribution! 🎉 |
Contributor
Author
Right on! Thank you for being open source! Take care y'all! |
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
+ description of `socket.readyState` Note: YAML tag found in commit e697cfb Co-authored-by: Michael Auderer <mike@silverstone.io> PR-URL: nodejs#35262 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds description of
socket.readyStatenet documentationNote that the
readyStateproperty was added in v0.5.0: e697cfbChecklist