doc: update process.release#35167
Conversation
nodejs-github-bot
added
doc
doc/api/process.md
Outdated
There was a problem hiding this comment.
If we're not going to maintain a list of all possible values, then I think we should change the preceding wording here from "Currently the valid values are:" to something like "Valid values may include:" to indicate that the following list is a subset. While "Argon" and others may no longer be supported they are still technically LTS release lines that someone could encounter.
There was a problem hiding this comment.
How about "Valid values include the LTS Release Codenames (including those that are no longer supported). A non-exhaustive example of these codenames includes:" ?
There was a problem hiding this comment.
Perhaps the links to Release schedule and Changelogs on Github should also be included?
There was a problem hiding this comment.
@schamberg97 That sounds good, feel free to add those 🙂
There was a problem hiding this comment.
I'll do it, but I am away from computer until midgnight
There was a problem hiding this comment.
We currently have a waiting period of 48 hours before we merge any non-trivial PR anyway, so take your time :)
There was a problem hiding this comment.
Sorry for the delay, had problems with my personal OSS project that was a bigger priority for me. This should probably be reviewed again, just in case
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Looks good to me, with or without the one suggestion I made.
|
Landed in 571dff8 |
|
Thanks for the contribution! 🎉 |
`process.release` documentation is out of date. This commit makes it up to date. PR-URL: #35167 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
`process.release` documentation is out of date. This commit makes it up to date. PR-URL: #35167 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
`process.release` documentation is out of date. This commit makes it up to date. PR-URL: #35167 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
`process.release` documentation is out of date. This commit makes it up to date. PR-URL: nodejs#35167 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
7 participants
Process.release doc is severely outdated. This PR includes info about LTS releases 10 and 12.
Checklist