meta: notify slack when someone force pushes#35131
Closed
mmarchini wants to merge 1 commit intonodejs:masterfrom
Closed
meta: notify slack when someone force pushes#35131mmarchini wants to merge 1 commit intonodejs:masterfrom
mmarchini wants to merge 1 commit intonodejs:masterfrom
Conversation
Notify #nodejs-dev on the OpenJS Foundation slack when someone force-pushes, removing one manual step from force-pushing.
nodejs-github-bot
added
the
meta
watilde
approved these changes
Sep 10, 2020
Member
|
It might be good to add a link of the Slack workspace to somewhere like CONTRIBUTING.md. |
Contributor
Author
|
Yup :) #35128 added on the same places we mention IRC except for the guidelines for force pushing (I didn't want to add another communication channel as requirement, so I decided to write this action instead) |
trivikr
approved these changes
Sep 10, 2020
addaleax
approved these changes
Sep 13, 2020
juanarbol
approved these changes
Nov 23, 2020
Trott
approved these changes
Nov 24, 2020
Member
|
nodejs/admin#551 was approved |
Contributor
Author
|
@targos yes, I have a huge backlog of PRs to close 😅. If anyone else wants to do it, feel free to do so. |
Member
|
I'd happily do it but I don't have the slack token ^^ |
Contributor
Author
|
Landed in 398add8 |
mmarchini
added a commit
that referenced
this pull request
Jan 5, 2021
Notify #nodejs-dev on the OpenJS Foundation slack when someone force-pushes, removing one manual step from force-pushing. PR-URL: #35131 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
Notify #nodejs-dev on the OpenJS Foundation slack when someone force-pushes, removing one manual step from force-pushing. PR-URL: #35131 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Notify #nodejs-dev on the OpenJS Foundation slack when someone force-pushes, removing one manual step from force-pushing. PR-URL: #35131 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by nodejs/admin#551
Notify #nodejs-dev on the OpenJS Foundation slack when someone
force-pushes, removing one manual step from force-pushing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes