Skip to content

test: remove setMaxListeners in test-crypto-random#35079

Merged
Trott merged 1 commit intonodejs:masterfrom
tniessen:test-remove-setmaxlisteners
Sep 9, 2020
Merged

test: remove setMaxListeners in test-crypto-random#35079
Trott merged 1 commit intonodejs:masterfrom
tniessen:test-remove-setmaxlisteners

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Sep 6, 2020

This appears to be a remnant from 413d38c. Since common.mustCall never registers more than one listener, it is unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessen tniessen added crypto Issues and PRs related to the crypto subsystem. events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 6, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33082/

@tniessen @Trott
test: remove setMaxListeners in test-crypto-random
f07f420 
This appears to be a remnant from
413d38c.

PR-URL: nodejs#35079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the test-remove-setmaxlisteners branch from ccd36da to f07f420 Compare September 9, 2020 15:16
@Trott
Copy link
Member

Trott commented Sep 9, 2020

Landed in f07f420

@Trott Trott merged commit f07f420 into nodejs:master Sep 9, 2020
ruyadorno pushed a commit that referenced this pull request Sep 17, 2020
@tniessen @ruyadorno
test: remove setMaxListeners in test-crypto-random
6627c1f 
This appears to be a remnant from
413d38c.

PR-URL: #35079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@tniessen @addaleax
test: remove setMaxListeners in test-crypto-random
d60c487 
This appears to be a remnant from
413d38c.

PR-URL: #35079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@tniessen @joesepi
test: remove setMaxListeners in test-crypto-random
a8d5520 
This appears to be a remnant from
413d38c.

PR-URL: nodejs#35079
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tniessen @nodejs-github-bot @Trott @lpinca @cjihrig