doc: add example for test structure#35046
Closed
wjabbour wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
Contributor
Author
|
@Trott |
Member
No strong opinion. On the one hand, sure, it makes the treatment of the sections consistent. On the other hand, the other segments are much shorter and that could be considered a good reason for including them but not this longer one. So, on balance, I could go either way. Let's ping a few others. @nodejs/testing |
Member
|
I think it's great to keep it consistent. |
Lxxyx
approved these changes
Jan 30, 2021
RaisinTen
approved these changes
Jan 30, 2021
Lxxyx
added
the
author ready
Lxxyx
pushed a commit
that referenced
this pull request
Feb 1, 2021
PR-URL: #35046 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Member
|
Landed in c746c40 🎉 |
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #35046 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #35046 Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
each part of the example was copy/pasted and talked about in detail, i matched the convention of also showing the example being detailed