Adds a fuzzer for LoadEnvironment#34844
Closed
DavidKorczynski wants to merge 5 commits intonodejs:masterfrom
Closed
Adds a fuzzer for LoadEnvironment#34844DavidKorczynski wants to merge 5 commits intonodejs:masterfrom
DavidKorczynski wants to merge 5 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
addaleax
approved these changes
Aug 19, 2020
github-actions
bot
removed
the
request-ci
bnoordhuis
reviewed
Aug 19, 2020
bnoordhuis
approved these changes
Aug 21, 2020
github-actions
bot
removed
the
request-ci
Collaborator
jasnell
approved these changes
Aug 21, 2020
joyeecheung
approved these changes
Aug 21, 2020
Contributor
Author
|
I was wondering if there is something in the PR I can help with in order to get this merged in? |
Member
|
@DavidKorczynski just looks like somebody needs to land it. Have requested a new CI and will try to remember to do it tomorrow. |
github-actions
bot
removed
the
request-ci
Collaborator
Member
|
There was a failure in CI run but looks like an issue that has been reported before: #34730 |
Contributor
Author
|
The code in this PR is self-contained in that it doesn't influence other aspects of NodeJS except for the fuzzer itself. And the fuzzer is not run in automated tests but only by way of https://github.com/google/oss-fuzz |
Member
|
Link to rebuild on OSX: https://ci.nodejs.org/job/node-test-pull-request/33493/ |
Collaborator
Member
|
New CI was good. Landing |
Contributor
Author
|
Thanks a lot @mhdawson |
Member
|
Landed as de7a1ab |
Merged
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Refs: nodejs#34761 Refs: nodejs#33724 PR-URL: nodejs#34844 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new fuzzer to run under OSS-Fuzz. The main function that this fuzzer targets is
node::LoadEnvironment.The fuzzer is inspired by the
cctesttest case.Cross-reference: #34761
Checklist